Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't push change of a framework version during the release to the main branch as we want to stay on 999-SNAPSHOT #1431

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Don't push change of a framework version during the release to the main branch as we want to stay on 999-SNAPSHOT #1431

merged 1 commit into from
Dec 11, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 11, 2024 •
edited
Loading

Summary

This should stop b2de7e1, I don't have required secrets to test this, so I limited changes to what I hope is safe. https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#pushChanges

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/stop-pushing-changes-during-release branch from 363b4c5 to a4c416a Compare December 11, 2024 00:41
rsvoboda
rsvoboda approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rsvoboda rsvoboda merged commit 1e9053d into quarkus-qe:main Dec 11, 2024
7 checks passed
@michalvavrik michalvavrik deleted the feature/stop-pushing-changes-during-release branch December 11, 2024 10:23
@michalvavrik michalvavrik mentioned this pull request Dec 11, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @rsvoboda